patches/monaco-editor.patch (3)

804-806: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Wrong model event method is invoked (runtime TypeError risk).

Line 805 calls model.onDidValidateModelVersion(listener), but the added model API is onDidValidateVersion(listener) (see Lines 757-767). This will fail at runtime.

Suggested fix

 export function onDidValidateModelVersion(model, listener) {
-    return model.onDidValidateModelVersion(listener);
+    return model.onDidValidateVersion(listener);
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@patches/monaco-editor.patch` around lines 804 - 806, The wrapper function
onDidValidateModelVersion incorrectly calls a non-existent model method; change
the call inside onDidValidateModelVersion to invoke the model's actual API
onDidValidateVersion(listener) so the wrapper delegates to
model.onDidValidateVersion and avoids the runtime TypeError.

---

241-253: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Delayer.cancel() now leaves pending promises unresolved.

On Line 253, completionPromise is nulled without resolving/rejecting it. Any caller awaiting the previous trigger() promise can hang indefinitely.

Suggested fix

 cancel() {
     this.cancelTimeout();
     if (this.completionPromise) {
-        // this.doReject?.(new CancellationError());
+        // Treat cancellation as a normal completion to avoid unhandled rejections.
+        this.doResolve?.(undefined);
+        this.doResolve = null;
+        this.doReject = null;
         this.completionPromise = null;
     }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@patches/monaco-editor.patch` around lines 241 - 253, Delayer.cancel()
currently clears completionPromise without resolving or rejecting it, which can
leave callers awaiting trigger() hanging; restore proper completion by invoking
the stored rejection/resolution callback when canceling: in the Delayer.cancel
method call this.doReject?.(new CancellationError()) or
this.doResolve?.(undefined) as appropriate before setting completionPromise =
null so any pending promise from trigger() completes, and ensure you reference
the existing symbols this.doReject, this.doResolve, completionPromise, and the
trigger() workflow when making the change.

---

951-962: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

TypeScript diagnostics still applies stale markers for newer model versions.

You capture modelVersionId (Line 943) but do not compare it before setModelMarkers (Line 955). If content changes during async validation, stale diagnostics can still be rendered.

Suggested fix

 if (model.isDisposed()) {
   return;
 }
 // PATCH: Don't apply model markers if the language has changed. (Aligns this behavior with other language services.) 
 if (model.getLanguageId() !== this._selector) {
   return;
 }
+if (model.getVersionId() !== modelVersionId) {
+  return;
+}
 editor.setModelMarkers(
   model,
   this._selector,
   diagnostics.map((d) => this._convertDiagnostics(model, d))
 );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@patches/monaco-editor.patch` around lines 951 - 962, The patch must avoid
applying stale diagnostics by verifying the model version before updating
markers: before calling editor.setModelMarkers and
editor.setModelVersionValidated, compare the captured modelVersionId with the
model's current version (e.g., model.getVersionId()) and early-return if they
differ; ensure you still check the language mismatch (model.getLanguageId() !==
this._selector) first, and only call setModelMarkers(this._selector,
diagnostics.map(d => this._convertDiagnostics(model, d))) and
editor.setModelVersionValidated(model, modelVersionId) when the modelVersionId
matches the model's current version.